Support 'domains' kwarg in loading

qa_srl2020.py

@@ -18,7 +18,7 @@
 import datasets
 from dataclasses import dataclass
 from pathlib import Path
-from typing import List, Tuple
+from typing import List, Tuple, Union, Set, Iterable
 import pandas as pd
 import json
 import gzip
@@ -88,10 +88,16 @@ _URLs = {
 
 SpanFeatureType = datasets.Sequence(datasets.Value("int32"), length=2)
 
+SUPPOERTED_DOMAINS = {"wikinews", "wikipedia"}
+
 @dataclass
 class QASRL2020BuilderConfig(datasets.BuilderConfig):
     """ Allow the loader to re-distribute the original dev and test splits between train, dev and test. """
     load_from: str = "jsonl" # "csv" or "jsonl"
+    
+    domains: Union[str, Iterable[str]] = "all" # can provide also a subset of acceptable domains.
+    # Acceptable domains are {"wikipedia", "wikinews"} for dev and test (qasrl-2020)
+    # and {"wikipedia", "wikinews", "TQA"} for train (qasrl-2018)
  
 
 class QaSrl2020(datasets.GeneratorBasedBuilder):
@@ -168,6 +174,22 @@ class QaSrl2020(datasets.GeneratorBasedBuilder):
     def _split_generators(self, dl_manager: datasets.utils.download_manager.DownloadManager):
         """Returns SplitGenerators."""            
         assert self.config.load_from in ("csv", "jsonl")
+        
+        # Handle domain selection
+        domains: Set[str] = [] 
+        if self.config.domains == "all":
+            domains = SUPPOERTED_DOMAINS
+        elif isinstance(self.config.domains, str):
+            if self.config.domains in SUPPOERTED_DOMAINS:
+                domains = {self.config.domains}
+            else:
+                raise ValueError(f"Unrecognized domain '{self.config.domains}'; only {SUPPOERTED_DOMAINS} are supported")
+        else:
+            domains = set(self.config.domains) & SUPPOERTED_DOMAINS
+            if len(domains) == 0:
+                raise ValueError(f"Unrecognized domains '{self.config.domains}'; only {SUPPOERTED_DOMAINS} are supported")
+        self.config.domains = domains
+        
 
         if self.config.load_from == "csv":
             # prepare wiktionary for verb inflections inside 'self.verb_inflections'
@@ -185,20 +207,20 @@ class QaSrl2020(datasets.GeneratorBasedBuilder):
                     name=datasets.Split.VALIDATION,
                     # These kwargs will be passed to _generate_examples
                     gen_kwargs={
-                        "qasrl_annotations_paths": [corpora["qasrl-annotations"]["wikinews.dev"], 
-                                                    corpora["qasrl-annotations"]["wikipedia.dev"]],
-                        "sentences_paths": [corpora["sentences"]["wikinews.dev"],
-                                            corpora["sentences"]["wikipedia.dev"]],
+                        "qasrl_annotations_paths": [corpora["qasrl-annotations"][f"{domain}.dev"] 
+                                                    for domain in domains],
+                        "sentences_paths": [corpora["sentences"][f"{domain}.dev"]
+                                            for domain in domains],
                     },
                 ),
                 datasets.SplitGenerator(
                     name=datasets.Split.TEST,
                     # These kwargs will be passed to _generate_examples
                     gen_kwargs={
-                        "qasrl_annotations_paths": [corpora["qasrl-annotations"]["wikinews.test"], 
-                                                    corpora["qasrl-annotations"]["wikipedia.test"]],
-                        "sentences_paths": [corpora["sentences"]["wikinews.test"],
-                                            corpora["sentences"]["wikipedia.test"]],
+                        "qasrl_annotations_paths": [corpora["qasrl-annotations"][f"{domain}.test"] 
+                                                    for domain in domains],
+                        "sentences_paths": [corpora["sentences"][f"{domain}.test"]
+                                            for domain in domains],
                     },
                 ),
             ]
@@ -238,6 +260,11 @@ class QaSrl2020(datasets.GeneratorBasedBuilder):
                 sent_obj = json.loads(line.strip())
                 tokens = sent_obj['sentenceTokens']
                 sentence = ' '.join(tokens)
+                sent_id = sent_obj['sentenceId']
+                # consider only selected domains
+                sent_domain = sent_id.split(":")[1]
+                if sent_domain not in self.config.domains:
+                    continue
                 for predicate_idx, verb_obj in sent_obj['verbEntries'].items():
                     verb_forms = verb_obj['verbInflectedForms']
                     predicate = tokens[int(predicate_idx)]
@@ -267,7 +294,7 @@ class QaSrl2020(datasets.GeneratorBasedBuilder):
                         
                         yield qa_counter, {
                             "sentence": sentence,
-                            "sent_id": sent_obj['sentenceId'],
+                            "sent_id": sent_id,
                             "predicate_idx": predicate_idx,
                             "predicate": predicate,
                             "is_verbal": True,