# 📋 Changelog - Watermark Leaderboard Fixes

## Version 2.0 - December 2024

### 🐛 Bug Fixes

#### 1. Fixed Submission Validation
**Problem**: Users could only submit Attack-free data. Watermark Removal and Stealing Attack submissions failed validation.

**Solution**: 
- Updated validation logic to accept any combination of attack types
- Users can now submit:
  - Only Attack-free data
  - Only Watermark Removal data  
  - Only Stealing Attack data
  - Any combination of the above

**Code Changes**:
```python
# Before: Required Attack-free fields
if normalized_utility is None or detection_rate is None:
    return "❌ Error: Normalized Utility and Detection Rate are required"

# After: Flexible validation
has_attack_free_data = normalized_utility is not None and detection_rate is not None
has_removal_data = absolute_utility_degradation is not None and removal_detection_rate is not None
has_stealing_data = adversary_bert_score is not None and adversary_detection_rate is not None

if not has_attack_free_data and not has_removal_data and not has_stealing_data:
    return "❌ Error: Please provide at least one complete set of metrics"
```

#### 2. Enhanced Pending Submissions Display
**Problem**: Pending submissions table only showed basic fields (ID, Name, Model, Normalized Utility, Detection Rate, Submitted At).

**Solution**: 
- Updated table to show ALL submission fields
- Administrators can now see complete submission details for proper review

**New Fields Displayed**:
- ID, Name, Model, Paper Link
- Attack-free Utility, Attack-free Detection
- Removal Degradation, Removal Detection  
- Adversary BERT, Adversary Detection
- Submitted At

### ✨ New Features

#### 1. Paper Link Field
- Added optional paper link field to submissions
- Links are displayed in the pending submissions table

#### 2. Enhanced User Guidance
- Added clear submission requirements in the form
- Better error messages with specific guidance
- Visual indicators for required vs optional fields

#### 3. Improved Form Labels
- Changed "Attack-free (Required)" to "Attack-free (Optional - Both Required if One is Provided)"
- Made it clear that all attack types are optional but pairs must be complete

### 🔧 Technical Improvements

#### 1. Better Validation Logic
- Separate validation for each attack type
- Clear error messages for each validation failure
- Consistent range validation across all metrics

#### 2. Enhanced Data Structure
- Improved pending submissions data formatting
- Better handling of optional fields
- Consistent data types across all metrics

#### 3. Updated Dependencies
- Added numpy requirement for better data handling
- Updated Gradio version compatibility

### 📊 User Experience Improvements

#### 1. Clearer Instructions
- Added submission requirements box in the form
- Better placeholder text and help information
- Consistent styling across all form sections

#### 2. Better Error Handling
- More specific error messages
- Guidance on how to fix validation errors
- Consistent error formatting

#### 3. Enhanced Admin Experience
- Complete field visibility in pending submissions
- Better table formatting with all metrics
- Improved approval workflow

### 🚀 Deployment Ready

All changes are compatible with Hugging Face Spaces and ready for immediate deployment. The fixes maintain backward compatibility while significantly improving functionality and user experience.