imgprcsng commited on
Commit
6c8e1f7
·
verified ·
1 Parent(s): f084855

Add missing ninja dependency

Browse files

Somehow ninja was missing in colab. Added that

Also changed `pip install .` to `python3 setup.py install` - some error with pip in resolving the path of extension (happening in python 3.12, didnt happen in 3.11)

Files changed (1) hide show
  1. notebooks/demo.ipynb +3 -3
notebooks/demo.ipynb CHANGED
@@ -133,7 +133,7 @@
133
  "# TODO check for gcc-11 or above\n",
134
  "\n",
135
  "# Install pip packages\n",
136
- "pip install --upgrade pip setuptools wheel\n",
137
  "pip install -r requirements.txt\n",
138
  "\n",
139
  "cd models/GroundingDINO/ops\n",
@@ -143,12 +143,12 @@
143
  " then\n",
144
  " echo \"failed to install wheel, trying to build from source\";\n",
145
  " python3 setup.py build\n",
146
- " pip install .\n",
147
  " fi\n",
148
  "else\n",
149
  " # We try to build the module as we dont know what environment we are running on\n",
150
  " python3 setup.py build\n",
151
- " pip install .\n",
152
  "fi\n",
153
  "python3 test.py"
154
  ]
 
133
  "# TODO check for gcc-11 or above\n",
134
  "\n",
135
  "# Install pip packages\n",
136
+ "pip install --upgrade pip setuptools wheel ninja\n",
137
  "pip install -r requirements.txt\n",
138
  "\n",
139
  "cd models/GroundingDINO/ops\n",
 
143
  " then\n",
144
  " echo \"failed to install wheel, trying to build from source\";\n",
145
  " python3 setup.py build\n",
146
+ " python3 setup.py install .\n",
147
  " fi\n",
148
  "else\n",
149
  " # We try to build the module as we dont know what environment we are running on\n",
150
  " python3 setup.py build\n",
151
+ " python3 setup.py install .\n",
152
  "fi\n",
153
  "python3 test.py"
154
  ]